[Popup] Misaligned positioning when parent has scrollbar#1918
Draft
lubber-de wants to merge 4 commits intofomantic:developfrom
Draft
[Popup] Misaligned positioning when parent has scrollbar#1918lubber-de wants to merge 4 commits intofomantic:developfrom
lubber-de wants to merge 4 commits intofomantic:developfrom
Conversation
lubber-de
added
type/bug
Contributor
|
The behavior is not the same with pre-formatted popup : https://jsfiddle.net/dutrieux/npgdc2mw/
|
lubber-de
added
the
state/on-hold
lubber-de
removed
the
state/awaiting-reviews
# Conflicts: # src/definitions/modules/popup.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Popups which are
rightpositioned are misaligned by the width of a possible scrollbar (or any margin of the parent element (usually body))Testcase
The body has a scrollbar.
Open the modal by clicking the button and hover over the icon to see the popup.
Broken
The popup arrow is misaligned to the right by the width of the body scrollbar
https://jsfiddle.net/dutrieux/npjsc5d8/
Fixed
Arrow positioned correctly again
https://jsfiddle.net/lubber/zh5xypob/
Screenshot
Broken
Fixed
Closes
#1899