fix(dropdown): direction calculation#2975
Open
alvarolm wants to merge 1 commit intofomantic:developfrom
Open
Conversation
fixes menu calculation while infering direction
Member
|
Could you please provide a jsfiddle to reproduce the issue and confirm your fix? Removing the hidden class before animating may has other visual impacts which needs testing |
Contributor
Author
|
will provide a reproducible case later, in the mean time here is the config used: may be could be a racing issue between parsing a relatively big json object and / or the async callback in can.openDownward() just below the calculations declaration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes menu calculation while inferring direction
when using the api settings, after the second request the menu list element has the
display: hidden !important;
css prop, producing a zero inner height of the menu during the direction calculation.