Do not flash loading class in modal refresh#2982
Do not flash loading class in modal refresh#2982mvorisek wants to merge 2 commits intofomantic:developfrom
Conversation
|
Remove the loading hack looks ok to me, but deleting the CSS is not a good idea IMHO. Some users might want to make their modals in a |
2f62015 to
57e6d87
Compare
|
I still do not understand the Semantic-Org/Semantic-UI@7450aa3 described in Semantic-Org/Semantic-UI#5578 (comment). Maybe flashing the I am closing this PR as I am unsure about this PR, we needed also the CSS removed (https://github.com/atk4/ui/blob/37a5a0b522/js/src/JqueryPlugin/ReloadViewPlugin.js#L53) and we worked around it on atk4 side. |
|
Jack was basically right: To be able to calculate/ access dimensions of DOM nodes, they have to be visible (to the browser, off canvas is fine, but display:none is not, as this does not occupy any visible space) |
introduced in Semantic-Org/Semantic-UI#5578
Is the hack using
loadingclass still needed? It causes a problem in out environment because it flashes the class causing our observers to trigger.Maybe more changes/LoC removed are needed/wanted.