Fix responding to external changes in .glyphspackage folders #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage: turns out Glyphs App replaces the *entire* .glyphspackage folder (with even all .glyph files having new mtimes) and we don't even receive change events for the files *inside* the .glyphspackage folder. So there's no easy way to make this more efficient than just reading everything back in
justvanrossum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed my bad assumption: it turns out Glyphs App replaces the entire .glyphspackage folder on "save", (with even all .glyph files having new modification times) and we don't receive change events for any files inside the .glyphspackage folder.
There's no easy way to make this more efficient than just reading everything back in. This is accomplished by removing the the specialized
fileWatcherProcessChangesmethod inGlyphsPackageBackend, and let the superclassGlyphsBackenddo the work.