Skip to content

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Jan 11, 2026

No description provided.

@github-actions
Copy link

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 121 19
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 372 15
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 382 15
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 144 5
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 156 5

Generated by 🚫 Danger

@github-actions
Copy link

TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^26 Test Results494 ran494 ✅
TestResult
No test annotations available

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.53%. Comparing base (dc4699b) to head (66922e2).
⚠️ Report is 273 commits behind head on master.

Files with missing lines Patch % Lines
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3967      +/-   ##
==========================================
+ Coverage   61.44%   62.53%   +1.09%     
==========================================
  Files         233      250      +17     
  Lines       21699    22501     +802     
==========================================
+ Hits        13332    14071     +739     
- Misses       8367     8430      +63     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.92% <98.27%> (+1.85%) ⬆️
Core 52.41% <72.44%> (+2.24%) ⬆️
SmartStore 73.66% <ø> (-0.02%) ⬇️
MobileSync 87.66% <ø> (-0.10%) ⬇️
Files with missing lines Coverage Δ
...forceSDKCore/Classes/Common/SalesforceSDKManager.m 57.14% <100.00%> (-0.69%) ⬇️
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 42.65% <100.00%> (+2.59%) ⬆️
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 86.53% <85.71%> (ø)

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results494 ran492 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
SFUserAccountManagerTests.testAuthHandler❌ failure
SalesforceRestAPITests.testInvalidAccessTokenWithInvalidRequest (failure 1/2)❌ failure
SalesforceRestAPITests.testInvalidAccessTokenWithInvalidRequest (failure 2/2)❌ failure

@bbirman bbirman merged commit cf8676c into forcedotcom:master Jan 13, 2026
20 of 27 checks passed
@bbirman bbirman deleted the welcome-flag branch January 13, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants