Skip to content

Conversation

@AlemTuzlak
Copy link
Contributor

Description

Added react-router middleware support to base-stack

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.46% 106 / 127
🔵 Statements 83.46% 106 / 127
🔵 Functions 55.55% 5 / 9
🔵 Branches 83.33% 5 / 6
File CoverageNo changed files found.
Generated in workflow #144 for commit 9d1a647 by the Vitest Coverage Report Action

@ivan-kleshnin
Copy link

ivan-kleshnin commented May 30, 2025

Hi @AlemTuzlak. Are you going to introduce some sort of DB connection/interaction template here, or do you think it'd be too opinionated ?

@AlemTuzlak
Copy link
Contributor Author

@ivan-kleshnin not in this stack, this is meant to be a minimalistic stack that can be used on any project (even the ones without a db) so we try to abide by that rule.

@AlemTuzlak
Copy link
Contributor Author

closing in favor of #55

@AlemTuzlak AlemTuzlak closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants