Fix rare FindrNumber/TermRenumber crashes when loading saves #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncommenting this line fixes crashes when loading certain save files, where the sizes of the terms have some interaction with SizeStoreCache. Changing that value or setting NumStoreCaches to 0 is a works-around also. Closes form-dev#420 and form-dev#484
tueda
approved these changes
Nov 29, 2024
Collaborator
tueda
left a comment
tueda
left a comment
There was a problem hiding this comment.
Good to go ahead. (Because creating simple test cases for this issue seems difficult, adding test cases is not necessary.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncommenting this line fixes crashes when loading certain save files, where the sizes of the terms have some interaction with SizeStoreCache.
Changing that value or setting NumStoreCaches to 0 is a works-around also.
Closes #420 and #484