Alleviate lock contention in the load balancing mechanism #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tueda
approved these changes
Jan 28, 2025
Collaborator
tueda
left a comment
tueda
left a comment
There was a problem hiding this comment.
This looks OK, but is 0.01s really necessary? Though it is a small amount, 10^7 clock cycles might be excessive.
Collaborator
Author
|
You are probably right. At least on my system sleeping for 1us is also enough to let valgrind run. Let's make it shorter. |
Add a small sleep in LoadReadjusted to allow threads to aquire the lock. This enormously speeds up some simple tform tests under valgrind.
jodavies
force-pushed
the
load-balancing
branch
from
8e29116 to
3948821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small sleep in LoadReadjusted to allow threads to aquire the lock. This enormously speeds up some simple tform tests under valgrind.
See also #600
This effectively just adds "a bit more waiting" to the already-existing
/* Wait a bit.... */comment.