Fixes for test 508 #718
Merged
Fixes for test 508 #718
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Error1 while holding ErrorMessageLock causes a hang in Terminate, when the thread attempts to take the long a second time. Use MesPrint to print the error instead.
This test fails on Fedora 42 with a ulimit of 8000000, though it passes on Ubuntu 24.04. Provide a bit more space, but still an insufficient amount for the memory leak being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix two issues related to the test for Issue 508, which I found to hang on Fedora 42. The first commit resolves the hang, when a tform thread fails a memory allocation. Now tform terminates as expected.
The second commit resolves the allocation failure by allowing a little more virtual memory for the test: Fedora42 apparently requires a bit more than Ubuntu for this test.
Closes #717