Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

Comments in AbstractToolEnvCommand.shouldIncludeCmdVar() and shouldIncludeHomeVar() incorrectly suggested conditional logic based on custom variable names, but the implementation unconditionally returns true in auto mode.

Changes

  • Clarified misleading comments: Updated comments to accurately reflect that auto mode always includes environment variables by default, removing the incorrect suggestion of conditional behavior
// Before (misleading):
// Auto: include if custom name provided, otherwise include by default
return true;

// After (accurate):
// Auto: include by default
return true;

The logic itself is correct—auto mode should include variables by default. Only the comments were inaccurate.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rsenden <8635138+rsenden@users.noreply.github.com>
Copilot AI changed the title [WIP] Update tool and CI configurations as per requirements Fix misleading auto-detection comments in AbstractToolEnvCommand Nov 14, 2025
Copilot AI requested a review from rsenden November 14, 2025 10:41
@rsenden rsenden closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants