Refactor stdio masking to reuse LogMaskHelper infrastructure and respect --log-mask level #890
+109
−113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdio masking implementation (
StdIoMaskHelper) duplicated pattern management logic fromLogMaskHelper, didn't respect the configured--log-masksensitivity level, and had design issues inMaskingPrintStreamcausing infinite recursion.Consolidate masking logic
LogMaskHelperwith stdio-specific methods:registerStdioPattern(),registerStdioValue(),maskStdio()stdioPatternReplacerfield for global stdio masking (separate from log message type-specific replacers)StdIoMaskHelperto delegate all pattern/value management toLogMaskHelperImplement conditional masking
isMaskingNeeded(LogSensitivityLevel)before registering patterns--log-masklevel from CLI optionsLogSensitivityLevel.highfor maximum protectionFix MaskingPrintStream design
ByteArrayOutputStreamin constructorMaskingOutputStreamclass that delegates writes directly to original stream's write methodCompatibility verification
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.