Open
Conversation
palkan
approved these changes
Aug 2, 2023
palkan
left a comment
palkan
left a comment
There was a problem hiding this comment.
Что-то получилось, но это какой-то хак!)
Всё так 🙂
криво работает проигрывание треков из фрейма
Да, это автоматически исправится после изменений в плеере. Сейчас это не нужно править.
А так всё отлично)
| @@ -0,0 +1,10 @@ | |||
| <%# locals: (artist:, tracks:, current_page:, next_page:, offset:, **) -%> | |||
|
|
|||
| <%= turbo_frame_tag "tracks-#{artist.id}-#{current_page}", target: "_top" do %> | |||
There was a problem hiding this comment.
Чуть получше, на мой взгляд, выглядит с dom_id:
Suggested change
| <%= turbo_frame_tag "tracks-#{artist.id}-#{current_page}", target: "_top" do %> | |
| <%= turbo_frame_tag dom_id(artist, :"tracks_#{current_page}"), target: "_top" do %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Необходимо добавить новую страницу со всеми треками артиста с ленивой подгрузкой треков при прокрутке (aka infinite scroll pagination). Использовать только Turbo Frames.