Open
Conversation
wmarshall
requested review from
Chess318,
Maheeshah07,
achatlos,
beccawilcox001 and
mhoughton26
mhoughton26
previously approved these changes
Oct 19, 2024
Contributor
mhoughton26
left a comment
mhoughton26
left a comment
There was a problem hiding this comment.
makes sense!
waiting on a mentor to approve, then it'll go in the code :)
mhoughton26
dismissed
their stale review
it doesn't actually conform with standards :(
mhoughton26
requested changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am normally anti-"mentors writing PRs", but I realized that explaining/documenting where this weird ratio came from might be worthwhile and I hadn't done so in any other way.
This code does not follow our new standards all the way - happy to move it and the giant comment into the DriveSubsystem class, or have it live wherever in the repo we find appropriate- please leave comments and ask questions before merging!