Add ability to have a callback at the start of the clickToFocus animation#82
Open
chilts wants to merge 1 commit intofredleblanc:masterfrom
Open
Add ability to have a callback at the start of the clickToFocus animation#82chilts wants to merge 1 commit intofredleblanc:masterfrom
chilts wants to merge 1 commit intofredleblanc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may or may not be the best name (focusCallback) since it would be better to rename clickToFocusCallback too but this would be backwards incompatible for all the users out there. Instead, I've tried to give it a name which makes sense - feel free to rename (one or both of these). Also added a no-op default.