Skip to content

Conversation

@rexxars
Copy link

@rexxars rexxars commented Dec 8, 2016

I might be overlooking something trivial here, but I can't see any way where length is not a number?
It's initialized as 0, so when you pipe an HTTP stream to it, it'll still be 0, and it'll just fall back and not try to read the length from the headers. Surely this isn't how it was supposed to be? :-)

Copy link

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Currently automatic length detection from streams is totally broken, and this would solve that nicely. @freeall can we get this merged and released?

@rexxars
Copy link
Author

rexxars commented Nov 26, 2017

Hate to "bump", but any thoughts on this?

@jmenashe
Copy link

jmenashe commented Dec 25, 2020

Don't mean to rush you but any chance of getting this addressed soon? ;)

For those of you looking for a workaround, you can initialize the progress-stream instance with the option{ length: 'any non-numeric value' }. If your readable stream has a length to be read then this should work fine. If it doesn't have a readable length then I'm assuming this will break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants