Skip to content

Conversation

@ungoldman
Copy link
Contributor

Noticed discussion on #18 has stalled, and I'm getting an unspecified warning for object-keys@0.4.0 when installing another package that depends on progress-stream. Thought I would just bump the deps in an isolated PR to move this forward and close #15.

@ungoldman ungoldman mentioned this pull request Apr 10, 2017
@freeall freeall merged commit bf0bca3 into freeall:master Apr 10, 2017
@freeall
Copy link
Owner

freeall commented Apr 10, 2017

Thanks @ungoldman. Released as 1.2.1.

@ungoldman ungoldman deleted the deps branch April 10, 2017 22:59
@ungoldman
Copy link
Contributor Author

Thanks @freeall! Looks like it didn't make it to the registry though 😢

https://www.npmjs.com/package/progress-stream === 1.2.0

@freeall
Copy link
Owner

freeall commented Apr 11, 2017

Try now :)

@thomas-riccardi
Copy link

Changing throught2 dependency from v0.2 to v2.0 is a major change: they migrated from Streams2 to Streams3, this may impact progress-stream users. Is this reasonable to push that with only a version bump on patch ?
This could be seen as a new feature: it provides Streams3 behavior, which should globally be backward compatible.
This could also be seen as a breaking change: in some cases Streams3 breaks Streams2 compatibility.

@freeall
Copy link
Owner

freeall commented Apr 11, 2017

@triccardi-systran very good point! I've unpublished 1.2.1 and published as 2.0.0 instead.

@thomas-riccardi
Copy link

Thanks for your quick action!

The "Streams2 vs Streams3" could also be documented on the master README, and a 1.x branch could be created too, with a similar warning on its README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade dependencies ?

3 participants