Conversation
Gradle support
freemansoft
reviewed
Jul 25, 2023
Owner
There was a problem hiding this comment.
We don't want binaries in the source tree
freemansoft
reviewed
Jul 25, 2023
Owner
There was a problem hiding this comment.
We don't want binaries in the source tree
Owner
|
Owner
|
It looks like the gradle code builds the package but not the DLLs. So this is a partial build. Some of the samples were in different character sets because they were part of defect reports related to character sets. A quick check makes it look like the source code is all UTF-8 CRLF. The DLL is loaded by copying it from the jar file into a temporary file system. That is a slick way to work with a single bundle but I'm not sure relying on a temp file to load a DLL is a good idea. Feels like a security issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I've created a new feature that I need in my use case which is:
I'm sharing my code in this pull request because with that we aren't too far to be able to create an automated continuous delivery to publish jacob dependency to maven central with the dll bundled, if you consider to merge this pull request then I can work to fix the issue #4 .
See another side features or fixes that I needed to achieve my objective:
You can check the results of this pull request by typing: