Additionally map string-parsed IDs when mapping coils#430
Open
Additionally map string-parsed IDs when mapping coils#430
Conversation
Owner
Author
|
Also need to check whether that doesn't screw up the coil statuses, because |
Collaborator
The treeview control used for switch and coil managers was update to support sorting by number here: |
Owner
Author
|
Ah, cool. Still want to support people prefixing names with "0" though. |
This was referenced Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a regression introduced when we cleared internal (
int) IDs in the GLE in favor of purely string-based IDs.The coil player currently blindly looks up the ID it gets from the GLE, which in the case of PinMAME, is a stringified integer. However, we often prefix coil IDs with "0" to get proper sorting, and it's also how they are named in the manual. So a "04" coil mapping won't match a "4" event from the GLE.
This patch additionally maps coils to their stringified integer, if it's not the same as the original name.
There will be another problem, the other way around, for switches. I will update this PR with a fix for that too, when I can reproduce.
I'll also do the same for lamps. @jsm174 let me know your thoughts already.