Skip to content

Mechanical sound support part 4 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freezy merged 85 commits into from
Jan 30, 2025
Merged

Mechanical sound support part 4 #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
ef93e17
initial commit
Mr-Jay-Gatsby Feb 13, 2023
288601d
Individual component implements ISoundEmitter, starting with flipper …
Mr-Jay-Gatsby Feb 15, 2023
ffc2c2c
Get the component that implements ISoundEmitter for pulling data to t…
Mr-Jay-Gatsby Feb 16, 2023
0bf2cc1
SoundInspector updates including refactor playroundrobin and playrand…
Mr-Jay-Gatsby Feb 16, 2023
5216c90
Further attempt to set pitch shifter value when testing sounds in the…
Mr-Jay-Gatsby Feb 18, 2023
3ba21d4
sound: Simplify sound asset and move play routine from inspector to a…
freezy Feb 18, 2023
ffcaf57
sound: Refactor editor classes.
freezy Mar 1, 2023
52dd038
sound: Get the runtime working.
freezy Mar 1, 2023
2c7b115
sounds: Clean up obsolete stuff.
freezy Mar 1, 2023
6c22ed6
style: Some comments and re-ordering.
freezy Mar 1, 2023
6867098
Minor fix to sound asset, in order to handle when audio clips length …
Mr-Jay-Gatsby Mar 3, 2023
ecf612e
Initial audio fade implementation.
Mr-Jay-Gatsby Mar 21, 2023
435a125
Updated fade handling. Added sound handling to the following componen…
Mr-Jay-Gatsby Mar 30, 2023
a808269
fix: UnityEditor reference.
freezy Jan 3, 2024
9bbd8e9
implement Stop action
linojon Jan 4, 2024
b8d7845
Dynamic audiosource for mechanical sound clips
linojon Jan 4, 2024
32a6244
populate AudioMixer prop by searching parents
linojon Jan 5, 2024
b96ddd8
added target sounds
linojon Jan 5, 2024
c5f5654
Q to exit play mode
linojon Jan 5, 2024
5f1d28e
wip drop targets reset and score motor sounds
linojon Jan 8, 2024
77e5460
trigger switch sounds
linojon Jan 5, 2024
6d59488
attempt to do target bank reset sound
linojon Jan 5, 2024
9aceef5
Update DropTargetBankApi.cs
linojon Jan 5, 2024
7d71b3f
wip drop targets reset and score motor sounds
linojon Jan 8, 2024
5978aa0
button to add MechSound with default volume=1
linojon Jan 30, 2024
ed14282
Apply default values to MechSound instances
arthurkehrwald Nov 25, 2024
9f99d3e
Fix UNT0026 warning
arthurkehrwald Nov 25, 2024
2951d76
Remove unused variable
arthurkehrwald Nov 25, 2024
1ac8d24
Do not change open scene when previewing sounds
arthurkehrwald Nov 25, 2024
3dac180
DropTargetBankComponent doesn't inherit MainRenderableComponent
arthurkehrwald Nov 25, 2024
ffc4dba
Complete score motor sound support
arthurkehrwald Nov 26, 2024
5d3627a
Rewrite inspectors and sound playback
arthurkehrwald Dec 3, 2024
c325750
Reimplement sound fading
arthurkehrwald Dec 5, 2024
db88d90
Add invalid sound asset warning
arthurkehrwald Dec 5, 2024
e1b4aee
Refactor sound playback
arthurkehrwald Dec 7, 2024
0761a23
Minor fixes to SoundsComponentInspector
arthurkehrwald Dec 10, 2024
198b01e
Remove MechSound class
arthurkehrwald Dec 12, 2024
8c6609a
Replace UI Toolkit inspector with IMGU
arthurkehrwald Dec 14, 2024
422cb25
Add interrupt option
arthurkehrwald Dec 14, 2024
acd1d54
Implement volume correction
arthurkehrwald Dec 14, 2024
6bef8fd
Add is spatial option
arthurkehrwald Dec 14, 2024
542050e
Back to UI Toolkit
arthurkehrwald Dec 14, 2024
966a6e2
Add interrupt field to SoundComponentInspector
arthurkehrwald Dec 14, 2024
2f92ae2
Code formatting
arthurkehrwald Dec 14, 2024
951dcfc
Tweak SoundComponentInspector margins
arthurkehrwald Dec 14, 2024
d15836d
Add audio mixer group option to SoundAsset
arthurkehrwald Dec 14, 2024
9ed147f
Make SoundTrigger fields readonly
arthurkehrwald Dec 14, 2024
6555762
Apply SoundEventArgs.Volume
arthurkehrwald Dec 14, 2024
e598e2a
Update sound asset inspector tooltips
arthurkehrwald Dec 20, 2024
f190990
Break up sound component into base and derived
arthurkehrwald Dec 20, 2024
25b1150
Add null check in SoundUtils
arthurkehrwald Dec 20, 2024
c9b42cf
Fix TriggerSoundComponentInspector.GetAvailableTriggers
arthurkehrwald Dec 20, 2024
045d003
Null check sound asset before playing
arthurkehrwald Dec 20, 2024
925d555
Add switch device sound
arthurkehrwald Dec 20, 2024
2ecf7ae
Add hit sound
arthurkehrwald Dec 20, 2024
e0a7fe6
Add coil sound
arthurkehrwald Dec 20, 2024
9bc8186
Rename SwitchDeviceSoundComponent
arthurkehrwald Dec 20, 2024
c1130f9
Consolidate event sound similarities into base class
arthurkehrwald Dec 20, 2024
a923e16
Rename some things
arthurkehrwald Dec 20, 2024
73ea2a2
Remove unused using from HitSoundComponent.cs
arthurkehrwald Dec 20, 2024
f252cce
Create base class for switch and coil sounds
arthurkehrwald Dec 20, 2024
82b9fde
Derive new NoIdCoilEventArgs from System.EventArgs
arthurkehrwald Dec 22, 2024
e4504c0
Remove ISoundEmitter
arthurkehrwald Jan 3, 2025
abb74af
Remove sound trigger
arthurkehrwald Jan 3, 2025
f032f2d
Add custom icons for components and sound assets
arthurkehrwald Jan 3, 2025
1f51b11
Remove null audio clips in GetClip
arthurkehrwald Jan 3, 2025
7605ccb
Log event source type correctly
arthurkehrwald Jan 3, 2025
b13f509
Init switches and coils in API constructors
arthurkehrwald Jan 3, 2025
f11c612
Fix: Set sound event source member
arthurkehrwald Jan 6, 2025
b6e8ac1
Fix: Use correct enable callback in SoundComponent
arthurkehrwald Jan 6, 2025
ff838ca
Prevent excessive hit sound spam
arthurkehrwald Jan 6, 2025
e64dcab
Use sound spam protection for all sound types
arthurkehrwald Jan 6, 2025
0863a25
Add summary comments
arthurkehrwald Jan 6, 2025
dd77977
Fix sound spam warning misfire
arthurkehrwald Jan 8, 2025
cbdb5fe
Move sound emitting prefabs to URP and HDRP repos
arthurkehrwald Jan 8, 2025
3eeed2c
Lower sound spam detection threshold
arthurkehrwald Jan 9, 2025
70fdd08
fix: Remove unused method.
freezy Jan 13, 2025
fc1d20c
style: Various improvements.
freezy Jan 14, 2025
633cb88
Remove null audio clips in inspector
arthurkehrwald Jan 16, 2025
2b8d93a
fix: Minor changes based on review comments.
freezy Jan 16, 2025
5f1ae60
plunger: Move collider states from states to collider.
freezy Jan 25, 2025
abfbd5a
physics: Move material LUTs out of the colliders (untested stil).
freezy Jan 26, 2025
e002c09
plunger: Adapt movement position, which is now relative to the plunge…
freezy Jan 28, 2025
dfd10c3
style: Put physics material into blocks.
freezy Jan 28, 2025
0aca735
physics: Fix LUTs based on velocities.
freezy Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ets/Resources/Prefabs/Plunger.prefab.meta → VisualPinball.Engine/VPT/MechSounds.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added VisualPinball.Unity/Assets/Editor/Icons/small_orange/musical_note.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
114 changes: 114 additions & 0 deletions VisualPinball.Unity/Assets/Editor/Icons/small_orange/musical_note.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added VisualPinball.Unity/Assets/Editor/Icons/small_orange/speaker.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
114 changes: 114 additions & 0 deletions VisualPinball.Unity/Assets/Editor/Icons/small_orange/speaker.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion VisualPinball.Unity/Assets/Presets.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 0 additions & 52 deletions VisualPinball.Unity/Assets/Resources/Prefabs/DropTargetBank.prefab
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions VisualPinball.Unity/Assets/Resources/Prefabs/DropTargetBank.prefab.meta
View file
Open in desktop

This file was deleted.

Loading
Loading