Merged
Conversation
…al version is selected and visible.
…n. Also, actually make use of gate collission min height.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a comprehensive update spanning several months covering animation system changes, material updates, asset browser improvements, and various bug fixes. The main purpose is to modernize the animation system using a publisher-subscriber pattern and update materials for HDRP 17 compatibility.
- New pub/sub-based animation system replacing direct component references
- Asset browser enhancements with improved material variations support
- Physics improvements and collision detection fixes
Reviewed Changes
Copilot reviewed 151 out of 152 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AnimationComponent.cs | Complete rewrite to use generic pub/sub pattern |
| IAnimationValueEmitter.cs | New interface for animation value emission |
| PhysicsEngine.cs | Updated to use new animation system dictionaries |
| Multiple component files | Implement IAnimationValueEmitter interface |
| Asset browser files | Enhanced material variations and UI improvements |
| Physics collision files | Bug fixes for collision detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
VisualPinball.Unity/VisualPinball.Unity/VPT/Gate/GateDisplacementPhysics.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are my changes from the last months. Will try to be more disciplined to better separate PRs.
Changes: