Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the segment display shader to improve maintainability by replacing global shader parameters with a structured context approach. The key change is eliminating global variables and parameter passing in favor of a centralized SegContext structure that encapsulates all segment display parameters.
- Introduces a
SegContextstruct to encapsulate all segment display parameters - Removes global shader variables and replaces them with context-based parameter passing
- Updates all segment display functions to accept and use the context structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SegmentDisplayShader.hlsl | Main shader refactoring: removes global variables, adds SegContext struct, updates all functions to use context parameters |
| SegmentDisplayGraph.shadergraph | Updates shader graph configuration to support the new context-based approach and removes deprecated HDRP emission node |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
VisualPinball.Unity/Assets/Shaders/Srp/Display/SegmentDisplayShader.hlsl
Show resolved
Hide resolved
VisualPinball.Unity/Assets/Shaders/Srp/Display/SegmentDisplayShader.hlsl
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation errors on latest Unity version, as well as the emission intensity issue.