component updates: handles when list is empty and handles async loading of list#108
Open
csantiago132 wants to merge 1 commit intofritx:devfrom
Open
component updates: handles when list is empty and handles async loading of list#108csantiago132 wants to merge 1 commit intofritx:devfrom
csantiago132 wants to merge 1 commit intofritx:devfrom
Conversation
Author
Owner
|
Thanks, just wait for my test case being ready and once the test passed in all cases I can merge it. |
Author
|
@fritx ok thanks for taking the time to review it! |
|
Any update regarding the merge of this pull request? |
Owner
|
@mirkos93 @csantiago132 sorry I can not merge the PR directly as it breaks the interface to users (for example, the prop is renamed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of updates to the component;
** Changes/Updates:**
New:
emptyListto display any custom component when list is emptyBreaking changes:
membersprop got changed tolist-membersthis is because the code is so couple to 'members' prop that its easier to change a prop instead of the whole codebase