Conversation
Owner
Author
|
Replaced by #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #38. This adds a function to calculate the timezone's offset that takes into account daylight savings for timezones which use it. Currently only several US timezones are implemented.
Any code which previously used the timezone's
offsetfield should be changed to use the newTimezone.dstOffsetfunction if DST support is needed.Since the daylight savings schedules vary for different timezones it also adds a
Date.fromNthWeekdayfunction to make it easier.This is only tested using a few simple testcases so there's likely some bugs lingering. Any feedback is welcome.