Rearranging the project to have Dependency Injection in one place#12
Open
shehabic wants to merge 1 commit intofrogermcs:masterfrom
shehabic-work:rearrangement
Open
Rearranging the project to have Dependency Injection in one place#12shehabic wants to merge 1 commit intofrogermcs:masterfrom shehabic-work:rearrangement
shehabic wants to merge 1 commit intofrogermcs:masterfrom
shehabic-work:rearrangement
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just rearrangement of the code, I totally get the point of the original arrangement, but it's not easy to find the D.I easily with the original structure.
mainly I introduced a new folder "dependencyinjection" and moved anything related to dagger into 3 folders within this one "modules", "components" and "scopes"