Change Logger.kt to use the Android Logging System#8
Open
UntitledMoose wants to merge 1 commit intoftcontrol:mainfrom
Open
Change Logger.kt to use the Android Logging System#8UntitledMoose wants to merge 1 commit intoftcontrol:mainfrom
UntitledMoose wants to merge 1 commit intoftcontrol:mainfrom
Conversation
Author
|
@MonsieurLazar Just a quick reminder ping! |
|
would be even better to use the RobotLog sdk log wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey y'all,
Would you consider switching to the Android
Logutility instead ofprintln, since the print statements can clutter logcat output and make debugging harder? This allows teams to filter out Panels debug statements more easily with a logcat rule (-tag:PANELS) in Android Studio, rather than having to disable them altogether withPanels.INSTANCE.getConfig().setEnableLogs(false).Thanks so much!
TLDR: Replaced
printlnstatements in theloganderrormethods withLog.dandLog.erespectively, using a consistentTAGfor all log messages to enable logcat filtering