use custom parquet-avro dependency #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use a custom patched version of the parquet-avro dependency (1.11.1-avro-fix) instead of the standard release version (1.11.1). The change introduces a new Maven property for the custom version and applies it to the parquet-avro dependency declaration.
Key Changes
- Added a new Maven property
parquet.fix.versionset to1.11.1-avro-fix - Updated the parquet-avro dependency to use the custom version property instead of the standard
parquet.version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <maven.compiler.target>1.6</maven.compiler.target> | ||
| <encoding>UTF-8</encoding> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <parquet.version>1.11.1</parquet.version> |
There was a problem hiding this comment.
Add a comment above this property explaining what issue the '-avro-fix' suffix addresses and where this custom artifact is maintained. This will help future maintainers understand why a non-standard version is being used.
Suggested change
| <parquet.version>1.11.1</parquet.version> | |
| <parquet.version>1.11.1</parquet.version> | |
| <!-- | |
| The '-avro-fix' suffix indicates a custom build of Parquet 1.11.1 that includes a fix for Avro compatibility issues | |
| encountered with the standard release. This custom artifact is maintained in the Pinterest fork at | |
| https://github.com/pinterest/parquet-avro-fix and published to our internal Maven repository. | |
| Please refer to the repository for details on the applied patch and maintenance. | |
| --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.