Some fixes for ubuntu benchmark #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* checking if mail transfer agent is configured for local only, the check was negated for some reason * checking for rsync service is uninstalled or masked, but is checking if rsync service is uninstalled and masked, the check should be an any check not an all check * For rsyslog config, the file creation setting should either be in rsyslog.conf or a file in rsyslog.d/ folder. For both to be true. So, changing the check from an all to an any * Before checking for the perission of sshd_config, we need to check if sshd is even in the system. So automatically passing the check if sshd is not present in the system
Contributor
Author
|
Reasoning behind the changes:
|
are tabs and not spaces. So changing the check to see for tabs and not spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found some mistakes/general improvements that can be made in the ubunu benchmark. This PR applies fixes for those