-
Notifications
You must be signed in to change notification settings - Fork 12
Create IntegrationTest #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Shouldn't integration tests for this application start the storm webserver and make some http requests instead of running Redis server? |
|
Yes, it should be, I will work on it. |
|
Try to create a new Issue and link to this PR where you describe the goal. |
ajohnsson95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, easier to read and cleaned up unnecessary code.
Charlottehenriksson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration test code looks organized and neat. :)
|
resolved minor conflicts in pom.xml and clienthandler |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
IntegrationTest
Create a Jedi pool that connects to the Redis container.
Performing a Redis operation, such as a set and goat.
Check that the operation was successful