Skip to content

Conversation

@Kouroshkt
Copy link
Contributor

IntegrationTest
Create a Jedi pool that connects to the Redis container.
Performing a Redis operation, such as a set and goat.
Check that the operation was successful

@kappsegla
Copy link
Contributor

Shouldn't integration tests for this application start the storm webserver and make some http requests instead of running Redis server?

@Kouroshkt
Copy link
Contributor Author

Yes, it should be, I will work on it.

@kappsegla
Copy link
Contributor

Try to create a new Issue and link to this PR where you describe the goal.

Copy link
Contributor

@ajohnsson95 ajohnsson95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, easier to read and cleaned up unnecessary code.

Copy link

@Charlottehenriksson Charlottehenriksson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration test code looks organized and neat. :)

@Demppas
Copy link
Contributor

Demppas commented Aug 16, 2024

resolved minor conflicts in pom.xml and clienthandler

@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants