Adds tests for ClientHandler

[Vimbayinashe]

Closes #42

Initially I tried to test if the method would throw an I/O Exception or not but I soon realised that the method itself never throws an Exception because it would already have been handled by the try-catch block in ClientHandler. I have therefore tested whether or not an error message has been logged in order to determine if an exception has been thrown.
Any input or improvements would be greatly appreciated 🙂.

[GreenGard]

What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called

Would this solve your first idéa?

Should we check if errormessages is greater than 0 instead of equal to 1?

[Vimbayinashe]

What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called Would this solve your first idéa?

Should we check if errormessages is greater than 0 instead of equal to 1?

I tried to throw an I/O Exception for Mockito.doThrow(IOException.class).when(socket.getInputStream()); but the exception is handled within the method's try-catch block and it does not throw an exception itself. The method will only log an error message if an exception has occured.
assertThatIOException().isThrownBy(clientHandler::run); is always false even if the socket is closed.

[Vimbayinashe]

What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called Would this solve your first idéa?
Should we check if errormessages is greater than 0 instead of equal to 1?

I tried to throw an I/O Exception for Mockito.doThrow(IOException.class).when(socket.getInputStream()); but the exception is handled within the method's try-catch block and it does not throw an exception itself. The method will only log an error message if an exception has occured. assertThatIOException().isThrownBy(clientHandler::run); is always false even if the socket is closed.

The run method only logs 1 message and it may similarly be an issue of concern if it deviates from its expected behaviour and logs 2 messages instead. That would then possibly be a bug in our logging system.

[Vimbayinashe]

Following updates to ClientHandler, issue #75 is required before tests to ClientHandler can be implemented.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud