Conversation
DevL
force-pushed
the
add-request-to-response
branch
from
bbb6b7b to
98e3178
Compare
Contributor
Author
|
We could pull in #6 as part of this work and the 2.0 release as well. 🤔 |
DevL
force-pushed
the
add-request-to-response
branch
from
98e3178 to
69c6a0b
Compare
Contributor
Author
DevL
force-pushed
the
add-request-to-response
branch
from
69c6a0b to
5ac693b
Compare
Co-authored-by: Lennart Fridén <lennart@devl.se>
Co-authored-by: Lennart Fridén <lennart@devl.se>
Co-authored-by: Lennart Fridén <lennart@devl.se>
Co-authored-by: Linus Huzell <linus.huzell@funnel.io>
This indicates the potentially breaking changes we're about to implement. Co-authored-by: Linus Huzell <linus.huzell@funnel.io>
DevL
force-pushed
the
add-request-to-response
branch
from
5ac693b to
20ec559
Compare
Co-authored-by: Linus Huzell <linus.huzell@funnel.io>
Co-authored-by: Linus Huzell <linus.huzell@funnel.io>
Co-authored-by: Lennart Fridén <lennart@devl.se>
Co-authored-by: Lennart Fridén <lennart@devl.se>
Co-authored-by: Lennart Fridén <lennart@devl.se>
This reverts commit 20ec559.
linus-funnel
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Responseobjects returned are not associated with thePreparedRequesttriggering them. This PR changes that.In addition, we intend to rework
fake_requestandfake_request_with_responseso that they, just likerequests.requestinvokes therequestmethod of aSessionobject, thus using more of therequestslibrary.