BlockHeaderRegistry by pmlambert · Pull Request #123 · fuseio/fuse-network

pmlambert · 2022-03-25T07:49:04Z

No description provided.

pmlambert · 2022-04-03T21:30:47Z

@leonprou I believe I'm supposed to sync up with you to figure out exactly how to structure the runtime logic for the changes. Everything works here, I just need to know exactly where you guys want to go with this feature. For example, who can submit signatures for which blocks (are cycles important), can validators submit signatures for multiple blocks at the same height, how many blocks should be confirmed before submitting the signatures, etc.

sirpy

contracts should not be here, they are irrelevant to the fuseapp
what are all the changes to fuseapp files not related to the bridge?
you are missing unit tests for the fuseapp bridge part, it is part of the bounty requirements
By default fuse+ethereum+bsc are always enabled no matter if they are in the list or not

app/index.js

scripts/quickstart.sh

app/index.js

Dockerfile.spark

sirpy · 2022-05-09T05:57:21Z

contracts should not be here, they are irrelevant to the fuseapp

what are all the changes to fuseapp files not related to the bridge?

you are missing unit tests for the fuseapp bridge part, it is part of the bounty requirements

By default fuse+ethereum+bsc are always enabled no matter if they are in the list or not

@pmlambert you missed the comment above

You are still not handling errors correctly in the .subscribe, better extract the whole .subscribe callback to a function

sirpy · 2022-05-09T06:00:17Z

app/index.js

+    logger.info('emitRegistry')
+    const currentBlock = (await web3.eth.getBlockNumber()).toNumber()
+    const chains = await blockRegistry.methods.getRpcs.call()
+    await Promise.all(chains.filter(chain => !blockchains[chain[0]] || blockchains[chain[0]].rpc != chain[1]).map(async (chain) => initBlockchain(...chain)))


if one initblockchain fail it shouldnt fail the whole function

still not done

sirpy · 2022-05-09T06:00:40Z

app/index.js

+      if (chainId == 122) {
+        let cycleEnd = (await consensus.methods.getCurrentCycleEndBlock.call()).toNumber()
+        let validators = await consensus.methods.currentValidators().call()
+        const numValidators = validators.length
+        blockchains[chainId].blocks[block.hash] = await signFuse(block, chainId, blockchain.provider, blockchain.signer, cycleEnd, validators)
+      }
+      else {
+        blockchains[chainId].blocks[block.hash] = await sign(block, chainId, blockchain.provider, blockchain.signer)
+      }
+    })


handle exceptions and extract to a function

pmlambert · 2022-05-09T07:13:33Z

contracts should not be here, they are irrelevant to the fuseapp
Deleted

what are all the changes to fuseapp files not related to the bridge?
From using rebase, has been fixed

you are missing unit tests for the fuseapp bridge part, it is part of the bounty requirements
That is step 3, this is for parts 1 and 2

By default fuse+ethereum+bsc are always enabled no matter if they are in the list or not
Changed to use env keys ETH,BSC _RPC

sirpy · 2022-05-09T12:17:54Z

contracts should not be here, they are irrelevant to the fuseapp
Deleted

what are all the changes to fuseapp files not related to the bridge?
From using rebase, has been fixed

you are missing unit tests for the fuseapp bridge part, it is part of the bounty requirements
That is step 3, this is for parts 1 and 2

By default fuse+ethereum+bsc are always enabled no matter if they are in the list or not
Changed to use env keys ETH,BSC _RPC

Every step has its own requirement for unit tests. you can check the bounty and check boxes again for each step.

sirpy · 2022-05-09T12:22:04Z

app/index.js

+  logger.info(`initBlockRegistryContract`, process.env.BLOCK_REGISTRY_ADDRESS)
+  blockRegistry = new web3.eth.Contract(require(path.join(cwd, 'abi/blockRegistry')), process.env.BLOCK_REGISTRY_ADDRESS)
+  initBlockchain(1, process.env.ETH_RPC || throw "Missing ETH_RPC in environment")
+  initBlockchain(56, process.env.BSC_RPC || throw "Missing BSC_RPC in environment"))


bsc has public rpc

sirpy · 2022-05-09T12:22:20Z

app/index.js

+function initBlockRegistryContract() {
+  logger.info(`initBlockRegistryContract`, process.env.BLOCK_REGISTRY_ADDRESS)
+  blockRegistry = new web3.eth.Contract(require(path.join(cwd, 'abi/blockRegistry')), process.env.BLOCK_REGISTRY_ADDRESS)
+  initBlockchain(1, process.env.ETH_RPC || throw "Missing ETH_RPC in environment")


use cloudflare eth endpoint

sirpy · 2022-05-09T12:22:39Z

app/index.js

+    logger.info('emitRegistry')
+    const currentBlock = (await web3.eth.getBlockNumber()).toNumber()
+    const chains = await blockRegistry.methods.getRpcs.call()
+    await Promise.all(chains.filter(chain => !blockchains[chain[0]] || blockchains[chain[0]].rpc != chain[1]).map(async (chain) => initBlockchain(...chain)))


still not done

sirpy · 2022-05-09T12:25:31Z

app/index.js

+      })
+    })
+  } catch(e) {
+    throw `emitRegistry failed trying to update rpcs`


i dont think that should prevent from calling addSignedBlocks part

sirpy · 2022-05-09T12:27:50Z

app/index.js

    }
    await emitInitiateChange()
    await emitRewardedOnCycle()
+    await emitRegistry()


i dont think an exception here should cause the fuseapp to exit

sirpy · 2022-05-09T13:49:38Z

app/index.js

+  try {
+    logger.info('emitRegistry')
+    const currentBlock = (await web3.eth.getBlockNumber()).toNumber()
+    const chains = await blockRegistry.methods.getRpcs.call()


should be getRpcs()
and that's why I want unit tests or testnet deployment with mock contracts to see that this whole process is working

BlockHeaderRegistry

f8f9cbe

pmlambert marked this pull request as ready for review March 25, 2022 07:49

Andrew-Pohl and others added 5 commits April 24, 2022 18:56

Update spark to OE 3.3.5 (fuseio#125)

35d6c1b

Pass bootnodes into the container (fuseio#124)

caa3287

Update bootnodes (fuseio#126)

9d32df8

Add abi and config for block registry

5488489

Fix logic for listening to new block headers

ab884bf

sirpy suggested changes May 2, 2022

View reviewed changes

Parker M. Lambert added 4 commits May 8, 2022 23:05

Deploy to mainnet

cb6079c

Merge branch 'master' of https://github.com/fuseio/fuse-network

9f4288a

Fix some issues with initBlockchain

edf0723

Fix issues outlined in review

d838980

sirpy suggested changes May 9, 2022

View reviewed changes

Parker M. Lambert added 3 commits May 9, 2022 02:57

Catch errors in block subscription

7a6b716

Bring requested changes

47040cb

Remove header registry contracts

3de0b53

sirpy suggested changes May 9, 2022

View reviewed changes

Export BlockRegistry functinos to separate file

7f81d05

Conversation

pmlambert commented Mar 25, 2022

Uh oh!

pmlambert commented Apr 3, 2022

Uh oh!

sirpy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sirpy commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmlambert commented May 9, 2022

Uh oh!

sirpy commented May 9, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sirpy commented May 9, 2022 •

edited

Loading