This repository was archived by the owner on Sep 26, 2021. It is now read-only.
Open
Conversation
gggeek
reviewed
Sep 2, 2019
| @@ -0,0 +1,20 @@ | |||
| version: "3.7" | |||
There was a problem hiding this comment.
q: any specific reason for requiring composer file format 3.7? The compose file seems pretty simple a first sight, and I would rather specify the lowest supported version of the format as general guideline....
Author
There was a problem hiding this comment.
Thats a good point, I did it out of habit. I'll check to see the lowest compatible version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a docker-compose file for easier build and setup. It uses the same configurations shown in the original
READMEwith the difference that it uses a named volume for greater flexibility.It also slightly changes the
Dockerfileto permit usage of more recent versions of Oracle XE