Handle object with missing properties in JSON schema#434
Merged
Conversation
mjperrone
approved these changes
Jun 17, 2025
Contributor
mjperrone
left a comment
mjperrone
left a comment
There was a problem hiding this comment.
May also want to bump the package version and add a note to the changelog in this PR if not in a following one.
| return self._parse(json_schema, alias_strategy) | ||
| types = [self._parse(s, alias_strategy) for s in type_list] | ||
| return UnionType(types, **extra_attrs) | ||
| case {"type": "object", "properties": properties}: |
Contributor
There was a problem hiding this comment.
TIL about match case binding - cool
Contributor
Author
The patch version gets bumped automatically as part of the publishing workflow so we're already good to go (cd99f87) |
adrianisk
force-pushed
the
adriank/object_missing_properties
branch
from
6e539b9 to
e7436fc
Compare
adrianisk
added a commit
that referenced
this pull request
Jun 17, 2025
# Summary Temporarily pins the `confluentinc` images in the integration test docker-compose file. Confluent recently [released version 8 of their images](https://hub.docker.com/r/confluentinc/cp-schema-registry/tags?ordering=name&name=8.0) which fail to start using the current config. Pinning to the latest 7.* version to unblock tests I'll rebase #434 once this is in Co-authored-by: Adrian Kreuziger <adrian@gable.ai>
adrianisk
force-pushed
the
adriank/object_missing_properties
branch
from
e7436fc to
e10f6b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small change to the
JSONSchemaConverterto handle objects with no "properties" keyword, which is technically valid{ "type": "object" }The output is the same as an object with
"properties": {}- aStructTypewith an empty fields array