jsonlogic: add IsOperation helper | cmake: add so-versioning#9
Open
hansbinderup wants to merge 2 commits intogabrielkim13:mainfrom
Open
jsonlogic: add IsOperation helper | cmake: add so-versioning#9hansbinderup wants to merge 2 commits intogabrielkim13:mainfrom
hansbinderup wants to merge 2 commits intogabrielkim13:mainfrom
Conversation
When implementing more complex logic it might be beneficial to know if the current entry is an operation. Example would be: if (IsOperation(j)) return Apply(j) else return CustomOperation(j) This allows traversing the tree and perform the "CustomOperation" on all but operations and otherwise handle the operations when finding such. Signed-off-by: Hans Binderup <habi@bang-olufsen.dk>
Versioning shared libraries is standard practice. This improves compatibility with most common packing systems. Signed-off-by: Hans Binderup <habi@bang-olufsen.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gabrielkim13 I had a few more patches lying around that I thought could be upstreamed. Let me know if they're of interest :)
The core is not tested so I didn't add a unit test for this method :)
Test and build results: