-
Notifications
You must be signed in to change notification settings - Fork 3
Improve file management for light emission simulations. #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: job-manager-simplification
Are you sure you want to change the base?
Improve file management for light emission simulations. #1981
Conversation
…tion-light-emission-package
…tion-light-emission-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves file management for light emission simulations by consistently using runner_services for directory and file naming, aligning with conventions used in other simulation production tools.
Changes:
- Refactored
SimulatorLightEmissionto userunner_servicesfor consistent file and directory management - Generalized
RunnerServicesto support bothCorsikaConfigand dict configurations - Removed
output_prefixparameter and updated file naming to match other simulation tools - Moved submission scripts and logs to
<output dir>/subsubdirectory
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/simtools/simtel/simulator_light_emission.py | Major refactoring to use runner_services, removed prefix logic, renamed methods |
| src/simtools/runners/runner_services.py | Added support for dict configs and iact_output file type |
| src/simtools/runners/simtel_runner.py | Renamed corsika_config parameter to config |
| src/simtools/runners/corsika_runner.py | Refactored to use runner_service.get_file_name() |
| src/simtools/runners/corsika_simtel_runner.py | Updated RunnerServices initialization with named parameters |
| src/simtools/simtel/simulator_array.py | Updated parent class initialization with named parameters |
| src/simtools/applications/simulate_flasher.py | Removed output_prefix parameter, added verify_simulations call |
| src/simtools/applications/simulate_illuminator.py | Removed output_prefix parameter, added run_mode to config |
| tests/unit_tests/test_simulator.py | Added zenith_angle to mock configuration |
| tests/unit_tests/simtel/test_simulator_light_emission.py | Updated tests for renamed methods and refactored implementation |
| tests/unit_tests/runners/test_simtel_runner.py | Updated test to use config parameter name |
| tests/unit_tests/runners/test_runner_services.py | Updated tests with named parameters, added new test case |
| tests/integration_tests/config/*.yml | Updated expected file paths to match new directory structure |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|



Improve file management for light emission simulations:
runner_servicesto have a consistent directory management.runner_servicesfor improved output and log file naming consistent with rest of simtools.e.g. the file tree for flasher simulations looks now like:
while before it looked like: