This repository was archived by the owner on Jun 27, 2025. It is now read-only.
Fix search issue with author and dedup_titles both selected#30
Open
TheDr1ver wants to merge 1 commit intogcrahay:masterfrom
Open
Fix search issue with author and dedup_titles both selected#30TheDr1ver wants to merge 1 commit intogcrahay:masterfrom
TheDr1ver wants to merge 1 commit intogcrahay:masterfrom
Conversation
There's an odd issue with PyMISP's search_index() function where it either truncates the search term at | or treats | as an OR statement. Either way, if you have a large DB filled with stuff like "Alienvault | Pulse Name" you'll get back results for every event that has Alienvault in the title. That is, unless you changing the | to \| right before searching, which is what this PR does.
|
Just out of curiosity, does this defect actually reveal a SQL injection vulnerability in the MISP search feature? I believe that search strings should never be parsed, so special characters like pipe (|) should have no effect if untrusted data is treated appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an odd issue with PyMISP's search_index() function where it either truncates the search term at | or treats | as an OR statement.
Either way, if you have a large DB filled with stuff like "Alienvault | Pulse Name" you'll get back results for every event that has Alienvault in the title. That is, unless you changing the | to | right before searching, which is what this PR does.