This repository was archived by the owner on Jun 27, 2025. It is now read-only.
Conversation
If creating a new event without any attributes attached to it, the API blocks the creation of the event and it will never make its way into MISP. Forcing published=False at this stage fixes the issue. Once the event has been populated the final publishing will be handled by ln 435.
|
Does this PR include everything in PR #33? |
Contributor
Author
|
All #33 does is set the default publish value to False, but the user can easily change that when they call create_event(). #36 makes sure publish is explicitly set to False throughout the creation of the event until the event has been populated with attributes, then takes the publish value into account at the very end. That all being said, I think if you use the code from PR #35 this largely becomes a moot point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If creating a new event without any attributes attached to it, the API blocks the creation of the event and it will never make its way into MISP. Forcing published=False at this stage fixes the issue. Once the event has been populated the final publishing will be handled by ln 435.