Skip to content

Conversation

@Bl00D4NGEL
Copy link
Contributor

@Bl00D4NGEL Bl00D4NGEL commented Feb 11, 2026

  • Match all src/app/code_D3810.c
  • Match uvDobjGetPosm
  • Match uvStrchr
  • Match all of src/app/code_D55B0.c & rename to wind_objects.c
  • Match most of src/app/code_D19D0.c,, except func_8034A4F8

@Bl00D4NGEL Bl00D4NGEL changed the title match: code_D3810.c, uvDobjGetPosm match: code_D3810.c, uvDobjGetPosm, uvStrchr Feb 11, 2026
@Bl00D4NGEL Bl00D4NGEL changed the title match: code_D3810.c, uvDobjGetPosm, uvStrchr Match funcs in src/apps Feb 11, 2026
@Bl00D4NGEL Bl00D4NGEL changed the title Match funcs in src/apps Match funcs in src/app Feb 11, 2026
#include <PR/ultratypes.h>

char* uvStrchr(const char* s, int c);
const char* uvStrchr(const char* s, const char c);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if aligning with strchr(), technically returns char* (no const). this is a bit awkward since it returns char* from const char* but the idea is the caller can use it for manipulation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I made this return a const char is that otherwise I get a warning during compilation:

src/kernel/string.c: In function ‘uvStrchr’:
src/kernel/string.c:15:16: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   15 |         return s;
      |                ^

Do we want to silence the warning here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants