Skip to content

Use setTimeout instead of recursive calls in service() #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dadibom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use setTimeout instead of recursive calls in service() #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/OutgoingFrameStream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ function service(stream) {
if (stream._destinationFinished) {
const error = new Error('cannot send frame on closed stream');
stream._frame.emit('error', error);
dequeue(stream);
setTimeout(dequeue.bind(this, stream), 0);
return;
}

Expand All @@ -226,12 +226,12 @@ function service(stream) {

if (!error) {
// Attempt next write operation
service(stream);
setTimeout(service.bind(this, stream), 0);
}
else {
// Send errors to subsequent write cbs and let the next
// frame attempt to write and cause an error
dequeue(stream);
setTimeout(dequeue.bind(this, stream), 0);
}
}

Expand Down