Replace assert with proper validation in channel_to_kraus()#134
Merged
gecrooks merged 1 commit intogecrooks:mainfrom Dec 19, 2025
Merged
Replace assert with proper validation in channel_to_kraus()#134gecrooks merged 1 commit intogecrooks:mainfrom
gecrooks merged 1 commit intogecrooks:mainfrom
Conversation
The function used assert statements to validate Choi matrix eigenvalues. This is problematic because assertions are disabled with `python -O`, allowing invalid channels to produce garbage Kraus operators (with NaN values from sqrt of negative numbers). Changes: - Replace asserts with if/raise ValueError - Add descriptive error messages with diagnostic info (actual values) - Add small tolerance (-1e-9) for numerical noise on negative check - Clamp tiny negative values to zero before sqrt to handle numerical noise - Add full docstring with Args, Returns, and Raises sections - Remove # TESTME comment (function is tested via test_askraus) Fixes gecrooks#131
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertstatements with properif/raise ValueErrorProblem
The function used assertions for critical validation:
Running
python -Odisables assertions, causing invalid channels to silently produce garbage Kraus operators with NaN values (fromsqrtof negative numbers).Demonstrated with
-Oflag before fix:Fix
Test plan
ValueError(notAssertionError)python -Oflagchannels_test.pytests pass (32 tests)Fixes #131