Skip to content

Comments

Add flexibility to run a changelog task during release#46

Closed
thiagocaiubi wants to merge 12 commits intogeddski:masterfrom
chaordic:master
Closed

Add flexibility to run a changelog task during release#46
thiagocaiubi wants to merge 12 commits intogeddski:masterfrom
chaordic:master

Conversation

@thiagocaiubi
Copy link

Fix #5

@drublic
Copy link
Collaborator

drublic commented Dec 2, 2014

I am currently collecting some PRs here and would love to see this landing. Want to take a look?

@drublic
Copy link
Collaborator

drublic commented Dec 3, 2014

Ok, so my work now moved to this repo. I will have a look into this PR asap since it's important for me to land it.
In the meantime it would be awesome if you could squash all your commits into one which describes the work you've done.

Thank you so much.

@drublic
Copy link
Collaborator

drublic commented Jan 5, 2015

Thanks for this again!

I've now implemented a way to update the changelog by not running other tasks but by updating the changelog itself. Please see 9ffe8d3. I think this is more useful.

The solution you implemented is not just the changelog task but another solution which gives implementors the possibility to run all tasks they want.
Please feel free to open another PR which does these callback tasks more generic if you are interested. Please also have a look at #59.

If you think the solution I provide is not great please let me know.

@drublic drublic closed this Jan 5, 2015
@thiagocaiubi
Copy link
Author

🆒 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support flexible changelog generation

2 participants