fix: exception is not imported sklearn.exceptions.NotFittedError#37
fix: exception is not imported sklearn.exceptions.NotFittedError#37kman0 wants to merge 4 commits intogeffy:masterfrom
Conversation
currently the error is "NameError: name 'sklearn' is not defined"
1. Added option to save init parameters 2. n_features from core (more can be added)
|
Hi! Thanks for contribution! Will check it carefully on weekends. |
|
Hi, @kman0! It seems like as-is this PR doesn't work. or it is supposed to be used in other way? |
|
@geffy my bad. I wanted to raise a pull req for the first commit alone! I was mainly working on Regression and didn't check it. The assertion error occurs because of the hard setting that loss_function cannot be set in case of Classifier. One way to overcome is to check if it is a TFFMClassifier instance and handle accordingly. I will post the changes shortly |
|
@geffy Your usage is correct. The primary reason why I wanted this was to train once and evaluate later. One addition that I would make is a call to predict function in the example for the sake of completeness
|
Currently the error is "NameError: name 'sklearn' is not defined" which is not the intended one as sklearn is not in scope. So adding a import statement.