feat(calendar): add sendUpdates parameter to createEvent#219
feat(calendar): add sendUpdates parameter to createEvent#219allenhutchison wants to merge 2 commits intomainfrom
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintaining the project's dependencies by updating several packages to their latest versions, ensuring compatibility and leveraging new features. It also introduces a new functional enhancement to the calendar event creation process, providing more granular control over attendee notifications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new sendUpdates parameter to the createEvent function in the Calendar service, allowing for more control over notifications. The changes include updating the tool definition, the service implementation, and adding corresponding tests. The dependency updates seem fine.
I've found one issue where the implementation for the default value of sendUpdates does not fully match the documented behavior. I've left a comment with a suggestion to fix it and to add a missing test case.
Address Gemini code review feedback: - Set sendUpdates to 'none' explicitly when no attendees are present (instead of leaving it undefined) - Add test case for no-attendees default behavior - Update existing test assertions to match new explicit default
42abf42 to
597a2ab
Compare
Summary
Fixes #190 —
calendar_createEventnow supports asendUpdatesparameter to control whether attendees receive calendar invitations.Changes
sendUpdatesfield toCreateEventInputinterface andcreateEventmethod. Defaults toallwhen attendees are present,noneotherwise.sendUpdatesas an optional enum parameter (all,externalOnly,none) on the tool schema.sendUpdates, attendee-present default (all), and no-attendee default (none).