Fix #131 Workspaces directories in server are not being found #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It won't conflict. The two systems are completely parallel. it just means many paths will be supplied twice. Looking at the diff, it seems to me you simply didn't set the But I'd need to investigate more deeply. The diffs are not very clear, mixing formatting and functional changes... In each case, The lazconfig system needs an update. Today you can simply use '/path/to/workspace/**' and the lazarus codetools will automatically add all subdirectories. So no special code required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mvancanneyt It was broken since your refactor but I fixed the usage of the includeWorkspaceFoldersAsUnitPaths which was supposed to add unit paths to FPCOptions. This for projects without lazarus so that you can open a workspace and it can find files for you with adding them manually.
My question is, how does this interact with the lazconfig system? I'm looking in PasLS.LazConfig.pas and I don't see how it sets unit paths. Now that this is working I think it's going to conflict with the lazconfig.