Skip to content

Conversation

@ingenarel
Copy link
Contributor

these variables and their docs can be found if you do man 5 ebuild,

however they're not in the devmanual itself

this pr should fix that

originally found it out because i was working on this: mfussenegger/nvim-lint#904

Copy link
Member

@ulm ulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: ingenarel (NeoJesus) <ingenarel_neojesus@disroot.org>
@ingenarel
Copy link
Contributor Author

ok i recommitted with the proper --signoff, fixed word wrapping to 80 chars as per the coding style, and added the necessary changes, if anything else is needed please lemme know

@ingenarel
Copy link
Contributor Author

ingenarel commented Feb 1, 2026

okay i have also properly did the note section

and also did <c></c> for the few stuff after some consideration:

  • "automake missing --run command" line, the --run
  • .GCC.command.line
  • .hash
  • SONAME

please lemme know if anything else is needed

@ulm ulm requested review from SoapGentoo and thesamesam February 1, 2026 12:46
<tr>
<ti><c>QA_AM_MAINTAINER_MODE</c></ti>
<ti>
This should contain a list of lines containing automake missing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please reword to avoid contain/containing in the same sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. I'd like to avoid these "This should contain..." but it's not something I insist on you fixing.

<tr>
<ti><c>QA_AM_MAINTAINER_MODE</c></ti>
<ti>
This should be a list of lines containing automake missing <c>--run</c>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make all of these "A list of ...". No need for "This should be" or "This should contain", it doesn't transport any additional information.

Signed-off-by: ingenarel (NeoJesus) <ingenarel_neojesus@disroot.org>
@ulm
Copy link
Member

ulm commented Feb 7, 2026

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants