Conversation
a17r
left a comment
a17r
left a comment
There was a problem hiding this comment.
- Please apply review globally
- Never use kde-apps/ category. Choose appropriate one.
- I'm wondering if there aren't some more
RDEPEND-only dependencies missing in general like kirigami, qtquickcontrols(2) etc.
| >=dev-qt/qtsql-${QTMIN}:5 | ||
| >=dev-qt/qtcore-${QTMIN}:5 | ||
| >=dev-qt/qtnetwork-${QTMIN}:5 | ||
| >=dev-qt/qtdeclarative-${QTMIN}:5 | ||
|
|
||
| >=dev-libs/mauikit-${KFMIN}:5 | ||
| >=kde-frameworks/ki18n-${KFMIN}:5 | ||
| >=kde-frameworks/kcoreaddons-${KFMIN}:5 | ||
| >=kde-frameworks/kconfig-${KFMIN}:5[qml] |
|
|
||
| DEPEND=" | ||
| >=dev-qt/qtsql-${QTMIN}:5 | ||
| >=dev-qt/qtcore-${QTMIN}:5 |
There was a problem hiding this comment.
dev-qt/qtcore is depended on by ecm.eclass already, you can drop it on all consumers.
| IUSE="" | ||
|
|
||
| DEPEND=" | ||
| sys-devel/gettext |
There was a problem hiding this comment.
definitely no RDEPEND. Likely BDEPEND?
| >=kde-frameworks/kcoreaddons-${KFMIN}:5 | ||
| >=kde-frameworks/kconfig-${KFMIN}:5[qml] | ||
| >=kde-frameworks/extra-cmake-modules-${KFMIN}:5 | ||
|
|
There was a problem hiding this comment.
no bogus newlines within strings please
dev-libs/mauiman/mauiman-9999.ebuild
Outdated
| # unsure, but mauikit is GPL3 | ||
| LICENSE="GPL-3" |
kde-apps/clip/clip-9999.ebuild
Outdated
| DEPEND=" | ||
| media-libs/taglib | ||
| media-video/ffmpeg | ||
| mpv? ( media-video/mpv[libmpv] ) |
There was a problem hiding this comment.
optional deps below unconditional deps
kde-apps/clip/clip-9999.ebuild
Outdated
|
|
||
| DEPEND=" | ||
| media-libs/taglib | ||
| media-video/ffmpeg |
| <pkgmetadata> | ||
| <use> | ||
| <flag name="mpv">Embed media-video/mpv for playback using libmpv</flag> | ||
| </use> | ||
| </pkgmetadata> |
|
Thanks, will fix all of it |
|
Please squash commits - when we merge this PR it shall be one clean commit per new package. We don't add review noise to ebuild repositories. I can see there are already fixing commits over multiple packages, it is easy in git to untangle again, visit #gentoo-dev-help if you need pointers. Though I'm not there right now because I'm on holidays. |
Sure, will do once I'm done! |
alfredfo
force-pushed
the
master
branch
2 times, most recently
from
b9c69eb to
b2b3134
Compare
Also makes mauikit depend on mauiman Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Needed for the Pix image viewer Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
|
@a17r: all done! Some of the licenses upstream are contradicting, but I got this response in Nitrux TG: So I set everything to LGPL-3. |
2 participants
This PR adds many Mauikit applications with dependencies. There are some left including the Station terminal. Station in particular uses qmltermwidget which needs some patches to run it seems.
Signed-off-by: Alfred Persson Forsberg cat@catcream.org