fix(sfx): Reload effect files when applying #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ok I just tested this a bit further and for some reason it only works one way (if you already have a pack applied it works, but if you're coming from the default and applying another pack it doesn't) so investigating that now |
Member
Author
|
I was iterating the sounds map wrong and skipping half of them so that's fixed now. Looks to be fully functioning from what I can tell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on Windows only.
To recreate the bug on 1.8.2:
This fixes the issue by forcing GD to reload the effect. Prior to this the effect was cached in a map, so it wouldn't recognize any changes during a reload.