Skip to content

Comments

Add TypeScript definition file#26

Open
moshest wants to merge 1 commit intogetconversio:masterfrom
moshest:patch-1
Open

Add TypeScript definition file#26
moshest wants to merge 1 commit intogetconversio:masterfrom
moshest:patch-1

Conversation

@moshest
Copy link

@moshest moshest commented Dec 4, 2019

No description provided.

@t5unamie
Copy link

Anyone know when this will be merged in?

@paoesco
Copy link

paoesco commented May 20, 2020

Hello,
interested in that one too :)

@ruscon
Copy link

ruscon commented Jun 18, 2020

ping

@moshest
Copy link
Author

moshest commented Jun 18, 2020

Notice we should also add "types": "lib/index.d.js", to package.json file in order for this to works.


interface VerifyResult {
wellFormed: boolean;
validDomain: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validDomain: boolean;
validDomain: boolean | null;

Will be null if verifyDomain is false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants