Open
Conversation
Member
|
This seems reasonable. The downside is this will only apply if you run the cord cli from a local version, and not from the official version. I can look at porting this code into the internal version which people would then get from npm. Thoughts @flooey? |
flooey
approved these changes
Jul 19, 2024
Member
flooey
left a comment
There was a problem hiding this comment.
This seems fine to me, but it's not ideal that it needs to buffer the entire response (which could be hundreds of megs) before it outputs it. But possibly it'd be much more difficult to feed it to stdout immediately as it comes in, so I'm not opposed.
| } | ||
|
|
||
| async function dbDumpHandler() { | ||
| const dump = await fetchCordManagementApi<ApplicationData[]>( |
Member
There was a problem hiding this comment.
This seems like it should be fetchCordManagementApi<string>
Contributor
Author
There was a problem hiding this comment.
true I'll change it
zephyring
referenced
this pull request
in fabi-ai/cord-preview
Jul 20, 2024
* Remove bucket for website backup * Remove DNS for various things Remove a bunch of DNS entries for stuff that was Cord-the-company related, but isn't necessary for the service, like the Cord website, Cord's hosted instance of Clack, etc. * Remove PR server The PR server isn't needed to run the service, and other customers wprobably want to have their own way of doing things rather than running our PR server exactly as it was run, so don't include it in the ops distribution. * Install pyOpenSSL before ec2instanceconnectcli * Create secrets for all .env secrets This makes the CloudFormation code create secret placeholders for all of the different secrets need to generate .env. The ones that are just random strings are initialized to random strings, while the ones that are external API keys are initialized to the string "INSERT API KEY HERE". * Fix names of secrets * Remove check for Cord's GitHub repo * Install Node 18 on build3 * Disable GitHub actions runner by default * Don't require running under GitHub actions in build-on-commit.sh * Don't attempt to push to getcord/monorepo on manual deploy * feat: add JSON log format (#8) * Disable stable host keys on zero by default * Add keyPair definition for radical-ec2-key * Don't customize app.cord.com bucket name * Update version of Postgres to 15 --------- Co-authored-by: Adam Vartanian <flooey@cord.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to dbDumps to Cord cli.
This is a nice to have feature to help everyone on the data migration process
Usage Examples local build:
Actual dump