-
Notifications
You must be signed in to change notification settings - Fork 215
Feature: Add devcontainer support #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
| assert_size /etc/secrets/enketo-secret 64 | ||
| assert_size /etc/secrets/enketo-less-secret 32 | ||
| assert_size /etc/secrets/enketo-api-key 128 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is already being discussed at #1110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1423 implementation should be used in favour of changes here
| PGUSER: jubilant | ||
| POSTGRES_INITDB_ARGS: -U jubilant | ||
| POSTGRES_PASSWORD: jubilant | ||
| POSTGRES_DB: jubilant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadiqkhoja how is docker-compose.dev.yml/make dev currently working without this postgres config? Presumably falling back to values defined at
Lines 9 to 12 in 4c30fb3
| environment: | |
| POSTGRES_USER: odk | |
| POSTGRES_PASSWORD: odk | |
| POSTGRES_DB: odk |
Lines 24 to 28 in 4c30fb3
| environment: | |
| PGUSER: odk | |
| POSTGRES_INITDB_ARGS: -U odk | |
| POSTGRES_PASSWORD: odk | |
| POSTGRES_DB: odk |
central-backend running in dev mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that #1112 is already asking the same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually create odk user in the dev db manually. I don't recreate database container as often so it's not a big deal for me.
|
Thanks for this PR. In the past we have seen other community members interested in running whole dev setup in containers but we parked that work until we have a clear and simple option to have following developer features:
Does this PR supports above two features? |
Blocked by:
Our team recently started working with ODK, and it wasn't easy for novice developers to run a development environment. We've successfully used devcontainers in other projects for a reproducible development environment and working on a server. This is the config we are using.
This PR includes commits from PRs #1110 and #1112 to make it works.
Also, it requires next changes to Vite config in client getodk/central-frontend#1274
What has been done to verify that this works as intended?
Started dev container using Visual Studio Code as per updated README.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)